build docker image #302
Merged
build docker image #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Balogh <[email protected]>
pbalogh-sa
force-pushed
the
docker-build
branch
from
89df294
to
17f44a5
Compare
orymate
commented
Sep 17, 2020
|
|
||
| ### Use Docker image | ||
|
|
||
| Logging in |
There was a problem hiding this comment.
We might add an example (with a random command) where no config file is mounted, and the base url and the token come from an env var.
Signed-off-by: Peter Balogh <[email protected]>
pbalogh-sa
force-pushed
the
docker-build
branch
3 times, most recently
from
f691616
to
b5ed720
Compare
Signed-off-by: Peter Balogh <[email protected]>
pbalogh-sa
force-pushed
the
docker-build
branch
from
b5ed720
to
2d7c827
Compare
Signed-off-by: Peter Balogh <[email protected]>
pbalogh-sa
approved these changes
Sep 18, 2020
pregnor
approved these changes
Sep 18, 2020
| # Install kubectl | ||
| ARG KUBECTL_VERSION=v1.16.1 | ||
| RUN curl -L -s https://storage.googleapis.com/kubernetes-release/release/${KUBECTL_VERSION}/bin/linux/amd64/kubectl -o /usr/local/bin/kubectl | ||
| RUN curl -L -s https://amazon-eks.s3-us-west-2.amazonaws.com/1.14.6/2019-08-22/bin/linux/amd64/aws-iam-authenticator -o /usr/local/bin/aws-iam-authenticator |
There was a problem hiding this comment.
Question: shouldn't we put the AWS IAM authenticator version (1.14.6) into an argument as well?
There was a problem hiding this comment.
Unfortunately, the release date is contained by the URL, so the proper date should be passed as well.
bonifaido
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build a docker image with all the runtime deps of banzai cli that can be used in a ci flow or a kubernetes task.